[webkit-reviews] review granted: [Bug 68839] De-virtualize JSCell::visitChildrenVirtual and remove all other visitChildrenVirtual methods : [Attachment 108755] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 68839: De-virtualize JSCell::visitChildrenVirtual and remove all other
visitChildrenVirtual methods
https://bugs.webkit.org/show_bug.cgi?id=68839

Attachment 108755: Patch
https://bugs.webkit.org/attachment.cgi?id=108755&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108755&action=review


> Source/JavaScriptCore/runtime/JSCell.cpp:37
> +void JSCell::visitChildrenVirtual(SlotVisitor& visitor)
> +{
> +    classInfo()->methodTable.visitChildrenFunctionPtr(this, visitor);
> +}

I think this should be inlined at the call site, not left as a cell member
function.