[webkit-reviews] review granted: [Bug 68833] Discard event data not followed by an empty line before eof when parsing an event-stream : [Attachment 108858] updated patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Per-Erik Brodin
<per-erik.brodin at ericsson.com>'s request for review:
Bug 68833: Discard event data not followed by an empty line before eof when
parsing an event-stream
https://bugs.webkit.org/show_bug.cgi?id=68833

Attachment 108858: updated patch
https://bugs.webkit.org/attachment.cgi?id=108858&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108858&action=review


> Source/WebCore/page/EventSource.cpp:318
> +	       if (!m_currentlyParsedEventId.isNull()) {

So, we're supposed to keep sending the same old last event id if subsequent
events don't have one? Weird.

> Source/WebCore/page/EventSource.h:118
>	   String m_lastEventId;

I now agree that keeping the name makes sense.