[webkit-reviews] review requested: [Bug 27238] Animated GIF dynamically removed and readded to page does not re-animate : [Attachment 108837] Fix for GIF not animating on dynamic detach & attach

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 27 06:32:18 PDT 2011


Ravi Phaneendra Kasibhatla <ravi.kasibhatla at motorola.com> has asked  for
review:
Bug 27238: Animated GIF dynamically removed and readded to page does not
re-animate
https://bugs.webkit.org/show_bug.cgi?id=27238

Attachment 108837: Fix for GIF not animating on dynamic detach & attach
https://bugs.webkit.org/attachment.cgi?id=108837&action=review

------- Additional Comments from Ravi Phaneendra Kasibhatla
<ravi.kasibhatla at motorola.com>
pkasting: Attached is a patch which fixes the issue. 
Patch ensures that any detach of the image element from the DOM also ensures
the image associated with the element (CachedResourceClient) is unregistered
with the CachedResource which was created while loading the image element. If
the CachedResource is not being referenced by any other client it is purged.
So, when the image element is reattached, it becomes new client which is
registered with the CachedResource and animation state is reset for it.


More information about the webkit-reviews mailing list