[webkit-reviews] review granted: [Bug 68369] [Qt][WK2] Add support for hover API in Qt WebKit2 : [Attachment 108767] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 68369: [Qt][WK2] Add support for hover API in Qt WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68369

Attachment 108767: Patch
https://bugs.webkit.org/attachment.cgi?id=108767&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108767&action=review


r=me

> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp:436
> +    if (linkURL != lastHoveredURL || linkTitle != lastHoveredTitle) {

I would write this as:
if (linkURL == lastHoveredURL && linkTitle == lastHoveredTitle)
    return;

> Source/WebKit2/UIProcess/qt/ClientImpl.cpp:167
> +void qt_wk_mouseDidMoveOverElement(WKPageRef page, WKHitTestResultRef
hitTestResult, WKEventModifiers modifiers, WKTypeRef userData, const void
*clientInfo)

Style, const void* clientInfo.

> Source/WebKit2/UIProcess/qt/ClientImpl.h:44
> +void qt_wk_mouseDidMoveOverElement(WKPageRef, WKHitTestResultRef,
WKEventModifiers, WKTypeRef, const void *clientInfo);

Ditto.