[webkit-reviews] review granted: [Bug 68613] Web Inspector: split DOM.attributesUpdated into attributeModified and attributeRemoved. Send attribute name and value within the event. : [Attachment 108677] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 68613: Web Inspector: split DOM.attributesUpdated into attributeModified
and attributeRemoved. Send attribute name and value within the event.
https://bugs.webkit.org/show_bug.cgi?id=68613

Attachment 108677: Patch
https://bugs.webkit.org/attachment.cgi?id=108677&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108677&action=review


> Source/WebCore/inspector/Inspector.draft-01.json:1182
> +		       { "name": "name", "type": "string", "description":
"Local attirbute name." },

typo: attirbute -> attribute, I'd also change it to Attribute's local name.

> Source/WebCore/inspector/Inspector.draft-01.json:1183
> +		       { "name": "value", "type": "string", "description":
"Attirbute name." }

Attirbute name. -> New attribute value.

> Source/WebCore/inspector/Inspector.json:1183
> +		       { "name": "value", "type": "string", "description":
"Attirbute name." }

Same typos here.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1681
> +	   this._parentPane._userOperation = true;

This lines don't seem to be a part of this change, remove them.