[webkit-reviews] review denied: [Bug 68592] wrap attribute of textarea element cannot be accessed by JavaScript : [Attachment 108811] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Vineet Chaudhary
<rgf748 at motorola.com>'s request for review:
Bug 68592: wrap attribute of textarea element cannot be accessed by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=68592

Attachment 108811: Patch
https://bugs.webkit.org/attachment.cgi?id=108811&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108811&action=review


> LayoutTests/fast/forms/textarea-wrap-attribute.html:17
> +//If wrap attribute is not specified it sould be empty String.

The comment is redundant.  Please remove it.

> LayoutTests/fast/forms/textarea-wrap-attribute.html:21
> +//Check if it sets warpAttr as hard

ditto.

> LayoutTests/fast/forms/textarea-wrap-attribute.html:22
> +debug('<br>Check if it sets warpAttr value hard, should return hard.');

We prefer using no HTML tags for debug().  Please write:

debug('');
debug('Check if ...

> LayoutTests/fast/forms/textarea-wrap-attribute.html:27
> +//Check if it sets warpAttr as soft
> +debug('<br>Check if it sets warpAttr value as soft, should return soft.');

ditto.

> LayoutTests/fast/forms/textarea-wrap-attribute.html:32
> +//If attribute present but no keyVal.
> +debug('<br>Check if warpAttr present but no keyVal specified, should return
empty String.');

ditto.

> LayoutTests/fast/forms/textarea-wrap-attribute.html:37
> +//If invalid attribute is set.
> +debug('<br>Check if it sets warpAttr invaild value, should return foo.');

ditto.