[webkit-reviews] review requested: [Bug 68592] wrap attribute of textarea element cannot be accessed by JavaScript : [Attachment 108811] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 27 01:48:40 PDT 2011


Vineet Chaudhary <rgf748 at motorola.com> has asked  for review:
Bug 68592: wrap attribute of textarea element cannot be accessed by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=68592

Attachment 108811: Patch
https://bugs.webkit.org/attachment.cgi?id=108811&action=review

------- Additional Comments from Vineet Chaudhary <rgf748 at motorola.com>
> > Source/WebCore/html/HTMLTextAreaElement.idl:4
> > + * Portions Copyright (C) 2011 Motorola Mobility, Inc.  All rights
reserved.
> You don't need to add "Portions".
Removed portions.

 
> > LayoutTests/fast/forms/textarea-wrap-attribute.html:10
> Do not add a separated .js file. This way is obsolete.
removed textarea-wrap-attribute.js, added the code to
textarea-wrap-attribute.html.


> > LayoutTests/fast/forms/script-tests/textarea-wrap-attribute.js:10
> > +//If wrap attribute present.
> This comment (and the followings) is useful information. Please print it to
the test result.  You can print it by debug('Check if wrap attribute present').


Added the debug statement to get more information on the test case.


More information about the webkit-reviews mailing list