[webkit-reviews] review denied: [Bug 68808] [Texmap][Qt] Refactor texture-upload to allow direct chunk update : [Attachment 108798] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 68808: [Texmap][Qt] Refactor texture-upload to allow direct chunk update
https://bugs.webkit.org/show_bug.cgi?id=68808

Attachment 108798: Patch
https://bugs.webkit.org/attachment.cgi?id=108798&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108798&action=review


> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:543
> +static void* swizzleBGRAToRGBA(void* data, const IntSize& size)

This function should take something more specific than a void*.
Also, it has a return type but no return statements.

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:548
> +	   uint* p = static_cast<uint*>(data) + y * (width * 4);

Is the number of bytes per row always guaranteed to be (width * 4)?

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:559
> +    void* swizzledBits = bits;

This appears to be unused.

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:586
> +	    break;

Wrong indentation.