[webkit-reviews] review denied: [Bug 24092] Autofocus readonly inputs : [Attachment 108796] Updated Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Kaustubh Atrawalkar
<kaustubh at motorola.com>'s request for review:
Bug 24092: Autofocus readonly inputs
https://bugs.webkit.org/show_bug.cgi?id=24092

Attachment 108796: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=108796&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108796&action=review


> LayoutTests/fast/forms/autofocus-readonly-attribute.html:9
> +function runTest()
> +{
> +    if (window.layoutTestController)
> +	   layoutTestController.dumpAsText();
> +}

It seems like there's no need for us to wrap this in a function. Please get rid
of the function and just run if & dumpAsText().

> LayoutTests/fast/forms/autofocus-readonly-attribute.html:12
> +    var ele = document.getElementById("console");

Please don't use the abbreviation "ele".