[webkit-reviews] review granted: [Bug 67253] NRWT should show the size of the pixel image delta in results.html : [Attachment 108773] add default value to mockExpectation() in results-test.js

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted  review:
Bug 67253: NRWT should show the size of the pixel image delta in results.html
https://bugs.webkit.org/show_bug.cgi?id=67253

Attachment 108773: add default value to mockExpectation() in results-test.js
https://bugs.webkit.org/attachment.cgi?id=108773&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108773&action=review


OK.

> Tools/Scripts/webkitpy/layout_tests/models/test_failures.py:171
> +    def __init__(self, diff_percent=0):
> +	   self.diff_percent = diff_percent

The pythonistas would tell you you should use =None and then "diff_percent or
0" in the body.  It doesn't matter because 0 is a constant, but if you were
using [] for example, you could hose yourself, since the "default" object is a
static and shared between all calls of the function.