[webkit-reviews] review denied: [Bug 60972] Audio element doesn't emit the 'playing' event every time it starts playing, after it has finished playing : [Attachment 108793] updated patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Arun Patole
<bmf834 at motorola.com>'s request for review:
Bug 60972: Audio element doesn't emit the 'playing' event every time it starts
playing, after it has finished playing
https://bugs.webkit.org/show_bug.cgi?id=60972

Attachment 108793: updated patch
https://bugs.webkit.org/attachment.cgi?id=108793&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108793&action=review


Much better, thanks! Just a last small issue to fix.

> LayoutTests/media/media-element-play-after-eos.html:21
> +		   mediaElement.currentTime = 1;    

Usually to seek near the end we use duration - 0.2 or something like that. It's
more explicit and more reliable if the test uses another media file in the
future.