[webkit-reviews] review denied: [Bug 68513] <input> with autofocus doesn't lose focus when it has a certain onblur listener : [Attachment 108637] Updated patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Rakesh <rakesh.kn at motorola.com>'s
request for review:
Bug 68513: <input> with autofocus doesn't lose focus when it has a certain
onblur listener
https://bugs.webkit.org/show_bug.cgi?id=68513

Attachment 108637: Updated patch
https://bugs.webkit.org/attachment.cgi?id=108637&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108637&action=review


> LayoutTests/fast/forms/autofocus-focus-only-once.html:22
> +    if (window.layoutTestController)
> +	   layoutTestController.dumpAsText();
> +

These lines are not needed. js-test-pre.js does it.

> Source/WebCore/html/HTMLFormControlElement.h:104
> +    bool hasAutofocused() { return m_hasAutoFocused; }
> +    void setAutofocused(bool autofocused = true) { m_hasAutoFocused =
autofocused; }
> +

Inconsistent capitalization: hasAuto*f*ocused vs. m_hasAuto*F*ocused
  Let's follow the capitalization of Document::m_ignoreAutofocus.  So it should
be m_hasAuto*f*ocused.

Also, we don't need to use the default argument for setAutofocused().
  void setAutofocused() { m_hasAutofocused = true; }
is enough.