[webkit-reviews] review canceled: [Bug 67253] NRWT should show the size of the pixel image delta in results.html : [Attachment 108773] add default value to mockExpectation() in results-test.js

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has canceled Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 67253: NRWT should show the size of the pixel image delta in results.html
https://bugs.webkit.org/show_bug.cgi?id=67253

Attachment 108773: add default value to mockExpectation() in results-test.js
https://bugs.webkit.org/attachment.cgi?id=108773&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
(In reply to comment #21)
> > LayoutTests/fast/harness/resources/results-test.js:37
> > +function mockExpectation(expected, actual, diff_percentage)
> 
> I would recommend having this default to None so you don't have to change so
many results.
> 

Good suggestion. Of course, I didn't actually know how to do that, so I've now
learned something as well. Done.