[webkit-reviews] review denied: [Bug 68828] DelayNode must set the context on delayTime AudioParam to support automation : [Attachment 108768] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 68828: DelayNode must set the context on delayTime AudioParam to support
automation
https://bugs.webkit.org/show_bug.cgi?id=68828

Attachment 108768: Patch
https://bugs.webkit.org/attachment.cgi?id=108768&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108768&action=review


The change and tests look good but there's a cleanup I think you should make to
the tests.

> LayoutTests/webaudio/resources/delay-testing.js:4
> +var toneBuffer;

These globals make the code difficult to understand. I think you should remove
them. Suggestions below on how to do so.

> LayoutTests/webaudio/resources/delay-testing.js:10
> +function createToneBuffer(frequency, numberOfCycles, sampleRate) {

Change this to accept context as an argument.

> LayoutTests/webaudio/resources/delay-testing.js:25
> +function checkDelayedResult(event) {

Take the toneBuffer as an argument to this function and return a function
taking the event:

function checkDelayedResult(toneBuffer) {
    return function(event) {
	// ...
    }
}

Then in the tests, set context.oncomplete = checkDelayedResult(toneBuffer).