[webkit-reviews] review granted: [Bug 67253] NRWT should show the size of the pixel image delta in results.html : [Attachment 108771] update smfr's patch to add more tests, fix style nits

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 67253: NRWT should show the size of the pixel image delta in results.html
https://bugs.webkit.org/show_bug.cgi?id=67253

Attachment 108771: update smfr's patch to add more tests, fix style nits
https://bugs.webkit.org/attachment.cgi?id=108771&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108771&action=review


Seems OK.

> LayoutTests/fast/harness/resources/results-test.js:37
> +function mockExpectation(expected, actual, diff_percentage)

I would recommend having this default to None so you don't have to change so
many results.

> LayoutTests/fast/harness/resources/results-test.js:446
> +    subtree['expected-to-pass-but-crashed.html'] = mockExpectation('PASS',
'CRASH', 0);

It seems mockExpectation should just have a default value for diff_percentage.