[webkit-reviews] review granted: [Bug 68824] [MutationObservers] implement MutationRecord : [Attachment 108757] Polymorphic, no MutationTypeFlag

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 68824: [MutationObservers] implement MutationRecord
https://bugs.webkit.org/show_bug.cgi?id=68824

Attachment 108757: Polymorphic, no MutationTypeFlag
https://bugs.webkit.org/attachment.cgi?id=108757&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108757&action=review


> Source/WebCore/dom/MutationRecord.cpp:61
> +    virtual const AtomicString& type();
> +    virtual NodeList* addedNodes() { return m_addedNodes.get(); }
> +    virtual NodeList* removedNodes() { return m_removedNodes.get(); }
> +    virtual Node* previousSibling() { return m_previousSibling.get(); }
> +    virtual Node* nextSibling() { return m_nextSibling.get(); }

These can be private.

> Source/WebCore/dom/MutationRecord.cpp:83
> +    virtual const AtomicString& type();
> +    virtual const AtomicString& attributeName() { return m_attributeName; }
> +    virtual const AtomicString& attributeNamespace() { return
m_attributeName; }
> +    virtual String oldValue() { return m_oldValue; }
> +    virtual void setOldValue(const String& val) { m_oldValue = val; }

These can be private.

We normally discourage use of abbreviations that are not words, so prefer value
over "val".

> Source/WebCore/dom/MutationRecord.cpp:100
> +    virtual const AtomicString& type();
> +    virtual String oldValue() { return m_oldValue; }
> +    virtual void setOldValue(const String& val) { m_oldValue = val; }

These can be private.

We normally discourage use of abbreviations that are not words, so prefer value
over "val".