[webkit-reviews] review granted: [Bug 62092] setting innerText to an empty string on editable div loses focus : [Attachment 108709] proposed patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Una Sabovic
<una.sabovic at palm.com>'s request for review:
Bug 62092: setting innerText to an empty string on editable div loses focus
https://bugs.webkit.org/show_bug.cgi?id=62092

Attachment 108709: proposed patch
https://bugs.webkit.org/attachment.cgi?id=108709&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108709&action=review


Thanks for the update. I'll land this patch manually and try to take care of
rebaselines.

> Source/WebCore/editing/htmlediting.cpp:926
> +void updatePositionForNodeRemoval(Node* node, Position& position)

I'd change this function to take Position first before landing since the
position is the primary object this function works on.