[webkit-reviews] review granted: [Bug 68741] Add static version of JSCell::getCallData : [Attachment 108609] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 68741: Add static version of JSCell::getCallData
https://bugs.webkit.org/show_bug.cgi?id=68741

Attachment 108609: Patch
https://bugs.webkit.org/attachment.cgi?id=108609&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108609&action=review


One thing that’s bad about the new functions is that they all have unchecked
type casts in them. It makes me wish there was some way to check the types in
all those cases are correct.

Looks like this did not build on Qt.

r=me if you address the Qt build failure

> Source/JavaScriptCore/ChangeLog:13
> +	   able to more easily store and refer to them in our custom vtable
since normal 

I’d say in our “method table” not our “custom viable”.

> Source/JavaScriptCore/ChangeLog:15
> +	   impossible to store them generically in ClassInfo.

I think I’d say something more like this: Function pointers are smaller and
more efficient to call than pointers to member functions, and using static
member functions allows us to use function pointers.