[webkit-reviews] review granted: [Bug 62092] setting innerText to an empty string on editable div loses focus : [Attachment 108694] proposed patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Una Sabovic
<una.sabovic at palm.com>'s request for review:
Bug 62092: setting innerText to an empty string on editable div loses focus
https://bugs.webkit.org/show_bug.cgi?id=62092

Attachment 108694: proposed patch
https://bugs.webkit.org/attachment.cgi?id=108694&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108694&action=review


Please fix below and I'll land it.

> LayoutTests/editing/selection/document-mutation.html:40
> +    checkResult(selection.getRangeAt(0).startOffset,
selection.getRangeAt(0).endOffset, expectedStartOffset, expectedEndOffset);

I feel like you can just call selection.getRangeAt(0).startOffset and
selection.getRangeAt(0).endOffset in checkResult but that's fine.

> LayoutTests/platform/qt/editing/inserting/typing-003-expected.txt:-3
> -EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY >
HTML > #document to 3 of DIV > BODY > HTML > #document
> -EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
> -EDITING DELEGATE:
webViewDidChangeSelection:WebViewDidChangeSelectionNotification

!? You need to modify typing-003.html to disable editing delegates if you were
to remove dumps in the expected result.

> LayoutTests/platform/qt/editing/selection/regional-indicators-expected.txt:5
> -FAIL document.getSelection().toString() should be 🇯🇵. Was 🇵.
> +FAIL document.getSelection().toString() should be 🇯🇵. Was .

I think we just need to call getSelection().removeAllRanges before the second
call to getSelection().addRange(afterLastIndicator);