[webkit-reviews] review granted: [Bug 68345] pop-state-event-constructor.html crashes and fails : [Attachment 108651] patch for review

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 26 11:52:07 PDT 2011


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 68345: pop-state-event-constructor.html crashes and fails
https://bugs.webkit.org/show_bug.cgi?id=68345

Attachment 108651: patch for review
https://bugs.webkit.org/attachment.cgi?id=108651&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108651&action=review


> Source/WebCore/ChangeLog:17
> +	   popped from HistoryItem, but we cannot deserialize the
SeriazliedScriptValue into

SeriazliedScriptValue => SerializedScriptValue

> Source/WebCore/ChangeLog:20
> +	   PopStateEvent still needs to provide an API to construct it with
SeriazliedScriptValue.

SeriazliedScriptValue

> Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp:46
> +    SerializedScriptValue* serializedState = event->serializedState();
> +    return serializedState ? serializedState->deserialize() :
event->state().v8Value();

Will this return undefined when the JSC version returns null?

> Source/WebCore/dom/PopStateEvent.cpp:61
> +    , m_state()

We usually omit this declaration when we're just calling the default
constructor.


More information about the webkit-reviews mailing list