[webkit-reviews] review requested: [Bug 62092] setting innerText to an empty string on editable div loses focus : [Attachment 108693] proposed patch

[bugzilla-daemon at webkit.org]

Una Sabovic <una.sabovic at palm.com> has asked  for review:
Bug 62092: setting innerText to an empty string on editable div loses focus
https://bugs.webkit.org/show_bug.cgi?id=62092

Attachment 108693: proposed patch
https://bugs.webkit.org/attachment.cgi?id=108693&action=review

------- Additional Comments from Una Sabovic <una.sabovic at palm.com>
Moved updatePositionForNodeRemoval to htmlediting instead of Position.

Removed editing delegates from LayoutTests/editing/inserting/typing-003.html
Calling runDumpAsTextEditingTest instead of runEditingTest also produced a lot
of output so I took the other approach.

> LayoutTests/platform/qt/editing/selection/regional-indicators-expected.txt:5
> +FAIL document.getSelection().toString() should be 🇯🇵. Was .
> This diff doesn't look good. Maybe you're missing some int'l package in your
system?

I was also suspicious about this one but it is the expected behavior. When
>> div.innerText = "��������"; // line 21
The entire content is deleted making selection (start, end) = (0, 0). Then new
content is inserted at the endpoints which doesn't move the start or end.
So we end up with an empty selection.
This test is strange with "FAIL" in its expected output.