[webkit-reviews] review denied: [Bug 68680] Let TestWebKitAPI work for chromium-win : [Attachment 108446] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 26 11:01:05 PDT 2011


Tony Chang <tony at chromium.org> has denied Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 68680: Let TestWebKitAPI work for chromium-win
https://bugs.webkit.org/show_bug.cgi?id=68680

Attachment 108446: patch
https://bugs.webkit.org/attachment.cgi?id=108446&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108446&action=review


> Tools/Scripts/webkitdirs.pm:164
> -	       # FIXME: set the correct baseProductDir for chromium-win.
> +	       $baseProductDir = "$sourceDir/Source/WebKit/chromium";

I think this is $sourceDir/Source/WebKit/chromium/build after chromium r102514.


More information about the webkit-reviews mailing list