[webkit-reviews] review granted: [Bug 68535] [chromium] Revise zoom animator backend to use full transform instead of just scale. : [Attachment 108584] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 26 10:42:37 PDT 2011


Kenneth Russell <kbr at google.com> has granted W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 68535: [chromium] Revise zoom animator backend to use full transform
instead of just scale.
https://bugs.webkit.org/show_bug.cgi?id=68535

Attachment 108584: Patch
https://bugs.webkit.org/attachment.cgi?id=108584&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108584&action=review


> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:296
> +	   m_context->clearColor(0.25, 0.25, 0.25, 1);

It's okay to use braces here because the arms (including comments) aren't
single-line.


More information about the webkit-reviews mailing list