[webkit-reviews] review granted: [Bug 68726] IndexedDB: Null key path gets stored as empty string key path : [Attachment 108681] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 26 10:28:25 PDT 2011


Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 68726: IndexedDB: Null key path gets stored as empty string key path
https://bugs.webkit.org/show_bug.cgi?id=68726

Attachment 108681: Patch
https://bugs.webkit.org/attachment.cgi?id=108681&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108681&action=review


> Source/WebCore/storage/IDBLevelDBBackingStore.cpp:215
> +bool checkObjectStoreAndMetaDataType(const LevelDBIterator* it, const
Vector<char>& stopKey, int64_t objectStoreId, int64_t metaDataType)

Nit: Should this function be static?


More information about the webkit-reviews mailing list