[webkit-reviews] review granted: [Bug 68633] Optimize matching of common pseudo classes : [Attachment 108662] new approach

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 26 08:58:27 PDT 2011


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 68633: Optimize matching of common pseudo classes
https://bugs.webkit.org/show_bug.cgi?id=68633

Attachment 108662: new approach
https://bugs.webkit.org/attachment.cgi?id=108662&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108662&action=review


This looks great, aside from a couple of boogers:

> Source/WebCore/ChangeLog:199
> +>>>>>>> .r95947

lolwut! :)

> Source/WebCore/css/SelectorChecker.cpp:417
> +//	 printf("checkSelector: %s\n", sel->selectorText().latin1().data());

oopsie :)


More information about the webkit-reviews mailing list