[webkit-reviews] review denied: [Bug 68602] [GTK[WK2][SOUP]Support for using proxy from environment variable : [Attachment 108639] proposed patch updated

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Wajahat Siddiqui
<mdwajahatali.siddiqui at motorola.com>'s request for review:
Bug 68602: [GTK[WK2][SOUP]Support for using proxy from environment variable
https://bugs.webkit.org/show_bug.cgi?id=68602

Attachment 108639: proposed patch updated
https://bugs.webkit.org/attachment.cgi?id=108639&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
I feel like this is still just a work-around. Soup knows how to integrate with
libproxy -- which is how we should be reading proxy variables. Even this patch
misses https_proxy, etc. We need to find a reasonable way to have Soup use
SOUP_TYPE_PROXY_RESOLVER_DEFAULT without reimplementing libproxy in the
WebProcess and without depending on Gnome libraries in WebKit.