[webkit-reviews] review denied: [Bug 68592] wrap attribute of textarea element cannot be accessed by JavaScript : [Attachment 108634] Updated Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Vineet Chaudhary
<rgf748 at motorola.com>'s request for review:
Bug 68592: wrap attribute of textarea element cannot be accessed by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=68592

Attachment 108634: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=108634&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108634&action=review


r- because of test style.

> Source/WebCore/html/HTMLTextAreaElement.idl:4
> + * Portions Copyright (C) 2011 Motorola Mobility, Inc.  All rights reserved.


You don't need to add "Portions".

> LayoutTests/fast/forms/textarea-wrap-attribute.html:10
> +<script src="script-tests/textarea-wrap-attribute.js"></script>

Do not add a separated .js file. This way is obsolete.
Please put the content of textarea-wrap-attribute.js into here, and remove
textarea-wrap-attribute.js.

> LayoutTests/fast/forms/script-tests/textarea-wrap-attribute.js:10
> +//If wrap attribute present.

This comment (and the followings) is useful information. Please print it to the
test result.  You can print it by debug('Check if wrap attribute present').