[webkit-reviews] review requested: [Bug 68633] Optimize matching of common pseudo classes : [Attachment 108662] new approach

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has asked  for review:
Bug 68633: Optimize matching of common pseudo classes
https://bugs.webkit.org/show_bug.cgi?id=68633

Attachment 108662: new approach
https://bugs.webkit.org/attachment.cgi?id=108662&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
In the end I wasn't happy with the original patch. Here is an updated patch
which takes slightly different approach. This uses separate lists for different
pseudo class types instead putting everything to a single list. This both
significantly faster (as the rightmost selector won't need any additional
checking for match) and cleaner (no need for awkward templating of
fastRejectSelector).

The patch also includes a bunch of cleanups as suggested by Darin.

Requesting a new review as the changes are substantial.