[webkit-reviews] review granted: [Bug 68662] Cleanup: Extract code to launch a Mac WebKit application into a common function : [Attachment 108504] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 68662: Cleanup: Extract code to launch a Mac WebKit application into a
common function
https://bugs.webkit.org/show_bug.cgi?id=68662

Attachment 108504: Patch
https://bugs.webkit.org/attachment.cgi?id=108504&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108504&action=review


> Tools/Scripts/webkitdirs.pm:2028
> +    if ($useOpenCommand == USE_OPEN_COMMAND) {
> +	   exec("open", "-a", $appPath, "--args", @ARGV);
> +    }

It's a little surprising that USE_OPEN_COMMAND also implies using exec()
instead of system(). Maybe we should have a separate parameter for that?