[webkit-reviews] review denied: [Bug 68695] Web Inspector: Timeline: record root event for the function calls enforced by console eval. : [Attachment 108483] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 68695: Web Inspector: Timeline: record root event for the function calls
enforced by console eval.
https://bugs.webkit.org/show_bug.cgi?id=68695

Attachment 108483: Patch
https://bugs.webkit.org/attachment.cgi?id=108483&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108483&action=review


> Source/WebCore/bindings/v8/ScriptFunctionCall.cpp:34
> +#include "DOMWindow.h"

Why do you need this?

> Source/WebCore/inspector/InjectedScript.cpp:194
> +    DOMWindow* domWindow =
domWindowFromScriptState(m_injectedScriptObject.scriptState());

domWindow may be 0, e.g. in case of worker context, r- for this.