[webkit-reviews] review requested: [Bug 67460] Add JSVALUE32_64 support to DFG JIT : [Attachment 108574] patch addressing Gavin's comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 23 20:18:40 PDT 2011
Yuqiang Xian <yuqiang.xian at intel.com> has asked for review:
Bug 67460: Add JSVALUE32_64 support to DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=67460
Attachment 108574: patch addressing Gavin's comments
https://bugs.webkit.org/attachment.cgi?id=108574&action=review
------- Additional Comments from Yuqiang Xian <yuqiang.xian at intel.com>
Gavin,
Thanks a lot for the review. Here's the new patch addressing your comments,
though some of issues are left to be handled, for example the unnecessary code
duplications and the arguments passing mechanism.
BTW, there's also another fix which included the recently added "BitVector.cpp"
in the wtf CMakeLists file to make the build succeed.
More information about the webkit-reviews
mailing list