[webkit-reviews] review granted: [Bug 68742] [chromium] Update VideoLayerChromium textures after texture resources are reclaimed : [Attachment 108564] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 23 17:42:51 PDT 2011


James Robinson <jamesr at chromium.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 68742: [chromium] Update VideoLayerChromium textures after texture
resources are reclaimed
https://bugs.webkit.org/show_bug.cgi?id=68742

Attachment 108564: Patch
https://bugs.webkit.org/attachment.cgi?id=108564&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108564&action=review


R=me

> Source/WebCore/ChangeLog:16
> +	   Additionally, fix a small bug in pushPropertiesTo where 1 plane RGB
> +	   videos would not get drawn because all 3 planes didn't have valid
> +	   textures.

do we ever actually have such a thing? can we just kill this codepath and
always use the YUV path?

> Source/WebCore/ChangeLog:18
> +	   Reviewed by NOBODY (OOPS!).

I dunno how you got 2 "reviewed by" lines here but I expect it'll kill some
script somewhere


More information about the webkit-reviews mailing list