[webkit-reviews] review denied: [Bug 68198] Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place : [Attachment 108545] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Varun Jain
<varunjain at chromium.org>'s request for review:
Bug 68198: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place
https://bugs.webkit.org/show_bug.cgi?id=68198

Attachment 108545: Patch
https://bugs.webkit.org/attachment.cgi?id=108545&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108545&action=review


>
LayoutTests/platform/chromium-linux/fast/dom/scroll-element-to-rect-centered-ex
pected.txt:6
> +PASS rect.left is 72
> +PASS rect.top is 144
> +PASS computedLeft is 72
> +PASS computedTop is 144
> +PASS successfullyParsed is true

Thanks for converting the test! Are these numbers going to be different from
platform to platform? If not, why are the expectations in platform-linux? If
yes -- can we do better? Can the test be more of a PASS/FAIL report, with the
assessment of the exact coordinates being platform-independent?