[webkit-reviews] review requested: [Bug 68723] Resolve opcodes should have value profiling. : [Attachment 108546] the patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has asked  for review:
Bug 68723: Resolve opcodes should have value profiling.
https://bugs.webkit.org/show_bug.cgi?id=68723

Attachment 108546: the patch
https://bugs.webkit.org/attachment.cgi?id=108546&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
This is pretty much performance neutral.  There is a spurious, but totally
reproducible, 0.3% slow-down in V8 on my MacBook Pro.  There are similarly
sized, though not as reproducible, speed-ups in SunSpider and Kraken.  I
checked and none of the benchmarks that have performance variations make any
use of any of the affected opcodes.  So these are just insignificant variations
due to code layout.