[webkit-reviews] review granted: [Bug 68727] Avoid updating compositing state during paint : [Attachment 108533] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 68727: Avoid updating compositing state during paint
https://bugs.webkit.org/show_bug.cgi?id=68727

Attachment 108533: Patch
https://bugs.webkit.org/attachment.cgi?id=108533&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108533&action=review


Would be great to have a test case.

> Source/WebCore/ChangeLog:10
> +	   fix this exact issue.  Based off the ChangeLog entries, I think that
this was just a typo.

One space after period.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:259
> -    case CompositingUpdateOnPaitingOrHitTest:
> +    case CompositingUpdateOnHitTest:

I'm not sure we even have to update compositing on hit testing, since that
doesn't have anything to do with compositing.