[webkit-reviews] review denied: [Bug 68722] Implicit conversion double to float in ShadowBlur::adjustBlurRadius : [Attachment 108524] Proposed build fix: add 2 variables with the proper cast.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 23 13:29:58 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 68722: Implicit conversion double to float in ShadowBlur::adjustBlurRadius
https://bugs.webkit.org/show_bug.cgi?id=68722

Attachment 108524: Proposed build fix: add 2 variables with the proper cast.
https://bugs.webkit.org/attachment.cgi?id=108524&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
I think m_blurRadius.scale(1 / static_cast<float>(transform.xScale()), 1 /
static_cast<float>(transform.yScale())); would be better.


More information about the webkit-reviews mailing list