[webkit-reviews] review granted: [Bug 68716] Add a bunch of unhandled node types to the propagator : [Attachment 108510] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 68716: Add a bunch of unhandled node types to the propagator
https://bugs.webkit.org/show_bug.cgi?id=68716

Attachment 108510: Patch
https://bugs.webkit.org/attachment.cgi?id=108510&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108510&action=review


> Source/JavaScriptCore/dfg/DFGPropagator.cpp:-610
> -	       ASSERT_NOT_REACHED();

Might still be nice to have an ASSERT_NOT_REACHED when the node type is not a
legal enum value. Sometimes we do that by using return instead of break, and
then asserting outside the switch statement.