[webkit-reviews] review requested: [Bug 68662] Cleanup: Extract code to launch a Mac WebKit application into a common function : [Attachment 108504] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 23 11:54:25 PDT 2011


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 68662: Cleanup: Extract code to launch a Mac WebKit application into a
common function
https://bugs.webkit.org/show_bug.cgi?id=68662

Attachment 108504: Patch
https://bugs.webkit.org/attachment.cgi?id=108504&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Updated patch based on Adam Roben's suggestions.

I added an optional argument $useOpenCommand to runMacWebKitApp() that when
equal to USE_OPEN_COMMAND will use the open(1) to launch the application.


More information about the webkit-reviews mailing list