[webkit-reviews] review denied: [Bug 68665] refactor RenderFlexibleBox to use flex-flow aware methods : [Attachment 108423] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 68665: refactor RenderFlexibleBox to use flex-flow aware methods
https://bugs.webkit.org/show_bug.cgi?id=68665

Attachment 108423: Patch
https://bugs.webkit.org/attachment.cgi?id=108423&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108423&action=review


> Source/WebCore/rendering/RenderBlock.h:-213
> -    // FIXME: Supporting layout deltas.
> -    void setLogicalLocationForChild(RenderBox* child, const LayoutPoint&);

Can you add a line in the ChangeLog explaining why this is being removed (e.g.,
unused).

> Source/WebCore/rendering/RenderFlexibleBox.cpp:116
> +LayoutUnit RenderFlexibleBox::hasOrthogonalFlow(RenderBox* child) const

Shouldn't this return a bool?

> Source/WebCore/rendering/RenderFlexibleBox.cpp:124
> +LayoutUnit RenderFlexibleBox::isHorizontalFlow() const

Shouldn't this return a bool?

> Source/WebCore/rendering/RenderFlexibleBox.cpp:130
> +LayoutUnit RenderFlexibleBox::isLeftToRightFlow() const

Shouldn't this return a bool?

> Source/WebCore/rendering/RenderFlexibleBox.cpp:415
> +	   // FIXME: I think we only want to do this for horizontal flows.

For vertical flows, we'll need something like this to compute the physical
width.