[webkit-reviews] review denied: [Bug 68238] Crash while loading http://www.jusco.cn : [Attachment 108476] JuscoCrashFix

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Nayan Kumar K
<nayankk at motorola.com>'s request for review:
Bug 68238: Crash while loading http://www.jusco.cn
https://bugs.webkit.org/show_bug.cgi?id=68238

Attachment 108476: JuscoCrashFix
https://bugs.webkit.org/attachment.cgi?id=108476&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> 5). While soup waits for response from network, webcore shared timer gets
triggered and it processes the above JavaScript

This is the bug in Soup back-end that needs to be fixed. Timers should not fire
during synchronous XMLHttpRequest. On other platforms, this is achieved by
running a nested event loop in a mode that doesn't handle any events except for
this particular load's network callbacks. E.g. in ResourceHandleCFNet.cpp:

    CFURLConnectionScheduleWithRunLoop(handle->connection(),
CFRunLoopGetCurrent(), synchronousLoadRunLoopMode());
...

    while (!client->isDone())
	CFRunLoopRunInMode(synchronousLoadRunLoopMode(), UINT_MAX, true);