[webkit-reviews] review denied: [Bug 63502] [EFL] Move GtkWidgetBackingStoreCairo to the cairo directory and modify to use in the EFL. : [Attachment 108437] Patch for WidgetBackingStoreCairo

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied  review:
Bug 63502: [EFL] Move GtkWidgetBackingStoreCairo to the cairo directory and
modify to use in the EFL.
https://bugs.webkit.org/show_bug.cgi?id=63502

Attachment 108437: Patch for WidgetBackingStoreCairo
https://bugs.webkit.org/attachment.cgi?id=108437&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108437&action=review


Much nicer, but please fix the minor stuff below. :)

> Source/WebCore/platform/cairo/WidgetBackingStoreCairo.cpp:23
> +#if (PLATFORM(GTK) && !defined(XP_UNIX)) || PLATFORM(EFL)

You shouldn't need this line. If a platform doesn't want to compile this file,
they just won't have it on their source list.

> Source/WebCore/platform/cairo/WidgetBackingStoreCairo.cpp:45
> +#elif PLATFORM(EFL)
> +    return adoptRef(cairo_image_surface_create(CAIRO_FORMAT_ARGB32,
size.width(), size.height()));
> +#else
> +    return nullptr;
> +#endif

It would be better to simply have

#if PLATFORM(GTK)
...
#else
    return adoptRef(cairo_image_surface_create(CAIRO_FORMAT_ARGB32,
size.width(), size.height()));
#endif