[webkit-reviews] review granted: [Bug 68662] Cleanup: Extract code to launch a Mac WebKit application into a common function : [Attachment 108416] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 68662: Cleanup: Extract code to launch a Mac WebKit application into a
common function
https://bugs.webkit.org/show_bug.cgi?id=68662

Attachment 108416: Patch
https://bugs.webkit.org/attachment.cgi?id=108416&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108416&action=review


It would be nice if run-webkit-app used this function, too.

> Tools/Scripts/webkitdirs.pm:2013
> +    return system $appPath, @ARGV;

While you're at it, it would be nice to switch this to the direct object form
of system() so that it will work correctly even if $appPath contains spaces and
@ARGV is empty.