[webkit-reviews] review denied: [Bug 68513] <input> with autofocus doesn't lose focus when it has a certain onblur listener : [Attachment 108453] Updated patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Rakesh <rakesh.kn at motorola.com>'s
request for review:
Bug 68513: <input> with autofocus doesn't lose focus when it has a certain
onblur listener
https://bugs.webkit.org/show_bug.cgi?id=68513

Attachment 108453: Updated patch
https://bugs.webkit.org/attachment.cgi?id=108453&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108453&action=review


r- because of test style.

> LayoutTests/fast/forms/autofocus-focus-only-once.html:6
> + input { background:red }
> + input:focus { background:lime }

One-space indentation looks strange.
Please remove the indentation.

> LayoutTests/fast/forms/autofocus-focus-only-once.html:12
> +<script language="JavaScript" type="text/javascript">
> +    function log(message) {
> +	   document.getElementById("console").innerHTML +=
"<li>"+message+"</li>";
> +    }
> +

Indenting the all of the content by four spaces is meaningless.  Please remove
the indentation.

> LayoutTests/fast/forms/autofocus-focus-only-once.html:30
> +	   if (document.activeElement == document.getElementById("input2"))
> +	       log("SUCCESS");
> +	   else
> +	       log("FAILURE");

You had better load LayoutTests/fast/js/resource/js-test-pre.js, and write
shouldBe('document.activeElement', 'document.getElementById("input2")').
See LayoutTests/fast/forms/autofocus-keygen.html, etc.