[webkit-reviews] review denied: [Bug 68592] wrap attribute of textarea element cannot be accessed by JavaScript : [Attachment 108332] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Vineet Chaudhary
<rgf748 at motorola.com>'s request for review:
Bug 68592: wrap attribute of textarea element cannot be accessed by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=68592

Attachment 108332: Patch
https://bugs.webkit.org/attachment.cgi?id=108332&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108332&action=review


> Source/WebCore/html/HTMLTextAreaElement.idl:40
> +	   attribute [Reflect] DOMString wrap;

Please insert this line at the next to "row" attribute. We'd like to follow the
IDL in the specification as possible.

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.
html#the-textarea-element

Also [Reflect] is wrong in this case.
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.
html#attr-textarea-wrap
If the wrap HTML attribute is missing, we need to return "soft" for the wrap
IDL attribute.

> LayoutTests/fast/forms/textarea-wrap-attribute.html:6
> +<textarea wrap="hard" cols="20"> This is a simple text-area1 </textarea> 
> +<textarea wrap="soft"> This is a simple text-area2 </textarea> 

The test coverage is too low.
- wrap HTML attribtue is missing
- wrap HTML attribute has an invalid value
- setting values to wrap IDL attribute
- ...

> LayoutTests/fast/forms/textarea-wrap-attribute.html:22
> +logResult("Text Area with hard wrap","hard", textArea.wrap);

You had better load fast/js/resources/js-test-pre.js, and write
shouldBe('textArea.wrap', '"hard"');