[webkit-reviews] review denied: [Bug 68541] Web Inspector: UI performance test for Scripts panel first open experience. : [Attachment 108328] [patch] initial version

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 68541: Web Inspector: UI performance test for Scripts panel first open
experience.
https://bugs.webkit.org/show_bug.cgi?id=68541

Attachment 108328: [patch] initial version
https://bugs.webkit.org/attachment.cgi?id=108328&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108328&action=review


> LayoutTests/inspector/performance/resources/first-open-scripts.html:30
> +	   setTimeout = originalSetTimeout;

Instead of overriding setTimeout which changes regular execution sequence we
should find an event that is fired definitely after the panel switch has
completed. If there is no such event at the moment we could expose
corresponding method on the panel for the test. Any of these seems better than
overriding setTimeout