[webkit-reviews] review granted: [Bug 68589] [Qt][Gtk] Wrong state when pausing a video in the "playing" event handler : [Attachment 108401] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 23 01:48:28 PDT 2011


Philippe Normand <pnormand at igalia.com> has granted Yael
<yael.aharon at nokia.com>'s request for review:
Bug 68589: [Qt][Gtk] Wrong state when pausing a video in the "playing" event
handler
https://bugs.webkit.org/show_bug.cgi?id=68589

Attachment 108401: Patch.
https://bugs.webkit.org/attachment.cgi?id=108401&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108401&action=review


Looks good, just a nit to fix before landing. Thanks!

> LayoutTests/media/video-paint-test.js:46
> +	       document.body.offsetLeft;

I don't think this is needed. I have no idea what the purpose of this is in the
other init function either ;) Can you remove it from initAndPause() please?


More information about the webkit-reviews mailing list