[webkit-reviews] review granted: [Bug 68488] garden-o-matic results view should sort test and builder names : [Attachment 108073] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 22 22:25:52 PDT 2011


Andy Estes <aestes at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 68488: garden-o-matic results view should sort test and builder names
https://bugs.webkit.org/show_bug.cgi?id=68488

Attachment 108073: Patch
https://bugs.webkit.org/attachment.cgi?id=108073&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108073&action=review


r=me

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/ui/results.js:172
> +	   Object.keys(resultsByTest).sort().forEach(function (testName) {

Super nit: you probably don't want that space before the anonymous function's
parameter list.


More information about the webkit-reviews mailing list