[webkit-reviews] review granted: [Bug 68669] Remove unneeded type conversion from background bleed code : [Attachment 108429] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 22 17:38:08 PDT 2011


Geoffrey Garen <ggaren at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 68669: Remove unneeded type conversion from background bleed code
https://bugs.webkit.org/show_bug.cgi?id=68669

Attachment 108429: Patch
https://bugs.webkit.org/attachment.cgi?id=108429&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108429&action=review


r=me

> Source/WebCore/rendering/RenderBoxModelObject.cpp:593
> +    adjustedRect.inflateX(-ceil(1 / transform.xScale()));
> +    adjustedRect.inflateY(-ceil(1 / transform.yScale()));

Maybe 1.0 would be clearer here.


More information about the webkit-reviews mailing list