[webkit-reviews] review granted: [Bug 68641] Text drawn via -webkit-background-clip:text should be non-blurry with all scaling techniques : [Attachment 108428] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 68641: Text drawn via -webkit-background-clip:text should be non-blurry
with all scaling techniques
https://bugs.webkit.org/show_bug.cgi?id=68641

Attachment 108428: Patch
https://bugs.webkit.org/attachment.cgi?id=108428&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108428&action=review


r=me, perhaps with a little more thought about the naming.

> Source/WebCore/platform/graphics/GraphicsContext.h:418
> +	   PassOwnPtr<ImageBuffer> createCompatibleBuffer(const IntSize&)
const;

I'm not sure that "compatible" says enough about the intent. It needs to
communicate "appropriately scaled", or use a term like "resolution" or "scale".
Maybe createScaledBuffer()?