[webkit-reviews] review denied: [Bug 68651] De-virtualize JSCell::getJSNumber : [Attachment 108405] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 68651: De-virtualize JSCell::getJSNumber
https://bugs.webkit.org/show_bug.cgi?id=68651

Attachment 108405: Patch
https://bugs.webkit.org/attachment.cgi?id=108405&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108405&action=review


Please make NumberObject-ness a type instead of a flag.

> Source/JavaScriptCore/runtime/JSTypeInfo.h:46
> +    static const unsigned IsNumberObject = 1 << 9;

I think this would be better as a JSType rather than a Structure flag. Flags
are states that many kinds of objects might have; types identify a specific
kind of object. Nothing other than NumberObject wants to set the IsNumberObject
flag.